-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete i686-unknown-linux-musl ucontext_t #2787 #2788
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
I tested it successfully with the reproduction steps explained in the issue, after patching all mentions of the |
@bors r+ |
📌 Commit e86eeec has been approved by |
💔 Test failed - checks-actions |
Tests are complaining about incomplete types. You probably need to include an additional header file in libc-test/build.rs. |
Friendly-ping, @victorpaleologue could you address the CI failure? |
Sorry I took so long to react. |
@bors r+ |
@victorpaleologue: 🔑 Insufficient privileges: Not in reviewers |
That was worth trying =p |
Contributors aren't allowed to r+ PRs in general otherwise anyone could push any changes to the master 😆 @bors try |
💔 Test failed - checks-actions |
@bors try |
💔 Test failed - checks-actions |
Sorry I'm using an arm64 processor and I don't understand yet how to run the i686 tests on my machine. Would you please trigger the CI again? |
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #2915) made this pull request unmergeable. Please resolve the merge conflicts. |
1fd4e88
to
89cd883
Compare
@bors try |
💔 Test failed - checks-actions |
Friendly-ping @victorpaleologue, are you still working on this? |
Not really. |
💔 Test failed - checks-actions |
I think this is a progress. Something's fishy with the FreeBSD 14 job, the error seems unrelated to my work. Let's ask @bors try again and hope this time it'll be ok. On my end I'll clean my commits. |
💔 Test failed - checks-cirrus-freebsd-14 |
FreeBSD 14 again. Perhaps I'll come back later to try again. |
8bb4cff
to
4843a09
Compare
The failure is unrelated to this PR, I'll address next week ;) (I'm on small vacation this week) |
@bors try |
💔 Test failed - checks-actions |
Hello, I think I am stuck, I do not know how to go further. I will close this PR now, but if anyone has an idea, please share! |
Fix #2787